You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If executing moduleCheckAuto with depths enabled, the reported depths will reflect the state of the project before any fixes were applied for the other rules.
One possible fix would be to have the FindingFactory differentiate between rules which may apply fixes and those which are report-only. This could be done by tagging the rules with a marker interface like ReportOnly.
If auto-correct is enabled, then the runner can run the rules which apply fixes first, then take a second pass (everything's cached anyway) for the report-only rules.
If auto-correct is disabled, then everything can be run at once.
DepthRule is currently the only one that is strictly report-only, and on a 300 module project, it executes in under a second. Running it in a second pass should have a very negligible performance impact.
The text was updated successfully, but these errors were encountered:
If executing
moduleCheckAuto
with depths enabled, the reported depths will reflect the state of the project before any fixes were applied for the other rules.One possible fix would be to have the
FindingFactory
differentiate between rules which may apply fixes and those which are report-only. This could be done by tagging the rules with a marker interface likeReportOnly
.If auto-correct is enabled, then the runner can run the rules which apply fixes first, then take a second pass (everything's cached anyway) for the report-only rules.
If auto-correct is disabled, then everything can be run at once.
DepthRule
is currently the only one that is strictly report-only, and on a 300 module project, it executes in under a second. Running it in a second pass should have a very negligible performance impact.The text was updated successfully, but these errors were encountered: