Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InheritedDependencyRule fails to auto-correct if it can't find the source project's declaration #459

Closed
RBusarow opened this issue Mar 18, 2022 · 0 comments · Fixed by #469
Labels
bug Something isn't working

Comments

@RBusarow
Copy link
Member

Assume some module has an "invisible" dependency which is applied by a convention plugin. That invisible dependency also provides a transitive dependency, and this transitive dependency qualifies as "inherited".

Because ModuleCheck copies the source declaration when auto-correcting, and it can't find the source, this auto-correct will fail.

In cases like this, it should be fine to just find the dependencies { ... } block and add the new dependency (1) above or below any other dependency of that configuration, or (2) at the bottom of the block. If there's no dependencies block at all, just create one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant