Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to Suppress used ViewBinding #710

Closed
tasomaniac opened this issue Jun 6, 2022 · 3 comments · Fixed by #712
Closed

Impossible to Suppress used ViewBinding #710

tasomaniac opened this issue Jun 6, 2022 · 3 comments · Fixed by #712
Labels
bug Something isn't working

Comments

@tasomaniac
Copy link
Contributor

I have a false-positive about view binding and it is unfortunately impossible to suppress.

I tried:

  • Putting suppress 1 line above
  • Same line
  • And also top of the file as @file:Suppress

ModuleCheck's error message

-- ModuleCheck results --

?    :developer-menu
?    ?       ?configuration?    dependency?    name                ?    source?    build file
?    ?    X  ?             ?              ?    disable-view-binding?          ?    /Users/taso/redacted/build.gradle.kts: (12, 9):
@RBusarow
Copy link
Member

RBusarow commented Jun 6, 2022

Thanks for the report. I can reproduce this, and for disable-android-resources as well. Looks like I never finished adding parsing suppresses for the android { ... } block stuff. I cannot think of a workaround for the current 0.12.2 version.

I should be able to merge a fix and get a new release out tonight.

@RBusarow RBusarow added the bug Something isn't working label Jun 6, 2022
@tasomaniac tasomaniac mentioned this issue Jun 6, 2022
Merged
RBusarow added a commit that referenced this issue Jun 7, 2022
@RBusarow
fix suppressing findings within the AGP DSL
2f23f6f 
fixes #710
RBusarow added a commit that referenced this issue Jun 7, 2022
@RBusarow
fix suppressing findings within the AGP DSL
9ea13ed 
fixes #710
RBusarow added a commit that referenced this issue Jun 7, 2022
@RBusarow
fix suppressing findings within the AGP DSL
b39dc87 
fixes #710
@RBusarow RBusarow mentioned this issue Jun 7, 2022
Merged
RBusarow added a commit that referenced this issue Jun 7, 2022
@RBusarow
fix suppressing findings within the AGP DSL
f51c1d7 
fixes #710
@kodiakhq kodiakhq bot closed this as completed in #712 Jun 7, 2022
kodiakhq bot pushed a commit that referenced this issue Jun 7, 2022
@RBusarow @kodiakhq
fix suppressing findings within the AGP DSL
3cc04af 
fixes #710
@tasomaniac
Copy link
Contributor Author

Thank you so much for quickly addressing this one.

@RBusarow
Copy link
Member

RBusarow commented Jun 7, 2022

Thanks for the report and the related fix!

RBusarow added a commit that referenced this issue Jun 8, 2022
@RBusarow
Merge branch 'main' into psi_resolution_WIP_2
db2aa40 
* main:
  add Algolia search to the website
  consume self again with version 0.12.3
  release docs for 0.12.3
  fix suppressing findings within the AGP DSL fixes #710
  Fix small false-positive for ViewBinding (#711)
  Update dependency com.vanniktech:gradle-maven-publish-plugin to v0.20.0

# Conflicts:
#	modulecheck-gradle/platforms/internal-android/build.gradle.kts
#	modulecheck-gradle/platforms/internal-jvm/build.gradle.kts
#	modulecheck-gradle/plugin/build.gradle.kts
#	modulecheck-parsing/psi/src/test/kotlin/modulecheck/parsing/psi/KotlinAndroidGradleParserTest.kt
#	modulecheck-rule/impl-factory/build.gradle.kts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix suppressing findings within the AGP DSL rickbusarow/ModuleCheck
2 participants
@tasomaniac @RBusarow