fix Dagger NoSuchMethodError for dagger.internal.Preconditions.checkNotNullFromProvides in SNAPSHOT
#570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dagger's `dagger.internal.Preconditions.checkNotNullFromProvides` is pretty new. If an old version of Dagger is in the build classpath of the target project, dependency resolution may resolve to that old version and cause a `NoSuchMethodError`. That new method is used in the Provider factory for static `@Provides` functions in `@Module` objects. Since I actually really hate qualifiers anyway, the chosen band-aid is to just create strong Provider types with injected constructors for each build property we need.
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dagger's
dagger.internal.Preconditions.checkNotNullFromProvidesis pretty new. If an old version of Dagger is in the build classpath of the target project, dependency resolution may resolve to that old version and cause aNoSuchMethodError.That new method is used in the Provider factory for static
@Providesfunctions in@Moduleobjects.Since I actually really hate qualifiers anyway, the chosen band-aid is to just create strong Provider types with injected constructors for each build property we need.