show file path for obsolete snapshots #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Feb 13, 2020
| const hasFailures = testResult.failureMessage || hasUncheckedSnapshots; | ||
|
|
||
| if (this.showPaths && hasFailures) { | ||
| this.stdio.log('\n' + test.path); |
There was a problem hiding this comment.
It should include some text I think, not just the path. log(`Obsolete snapshot at ${test.path}`) or something?
There was a problem hiding this comment.
That text will be logged via helpers.getSnapshotStatus L60
There was a problem hiding this comment.
added result example in the description.
|
@SimenB Would you be able to approve this or it has to be merged by @rickhanlonii ? |
|
No sorry, I have neither commit nor publish access here |
|
@rickhanlonii assuming this was closed due to master branch deletion - should change the target branch here |
|
Hey @ron23, sorry this slipped - can you re-create targeted at the current main branch? |
|
Hey @rickhanlonii no worries I just created it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a test fail due to obsolete snapshot, it's impossible to tell which file has the snapshots.
The filePath flag only address an actual test failure (via asserting
testResult.failureMessage).This PR adds support to show filePath for obsolete snapshots as well.
This tries to solve the same problem reported here #15 but instead of showing the report, simply show the file path for where the error occurred.
The result