Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow install to system-wide Python #14

Merged
merged 1 commit into from
Jun 7, 2024
Merged

feat: allow install to system-wide Python #14

merged 1 commit into from
Jun 7, 2024

Conversation

rjhenry
Copy link
Contributor

@rjhenry rjhenry commented May 14, 2024

No description provided.

@ricsanfre
Copy link
Owner

ricsanfre commented May 18, 2024

Hi @rjhenry, thanks for creating this PR,

Instead of adding a hardcoded environment variable in the Ansible's playbook, I would rather prefer to have a new Ansible var pip_environment_var containing a list of environment variables that need to be passed to pip command execution.

Could you please update the PR so that generic variable can be used?

Thanks
Regards
Ricardo

In order to allow installation to system-wide Python libraries, Pip must
be configured with an environment variable as of version 23.0.1. This
allows setting that variable, as well as any others.
@rjhenry
Copy link
Contributor Author

rjhenry commented May 18, 2024

Instead of adding a hardcoded environment variable in the Ansible's playbook, I would rather prefer to have a new Ansible var pip_environment_var containing a list of environment variables that need to be passed to pip command execution.

I went with minio_pip_environment_vars, mostly to indicate the scope of the variable in it's name.

@rjhenry
Copy link
Contributor Author

rjhenry commented May 26, 2024

Looks like those Molecule tests are a) only warnings and b) also happening on master now. I suspect something's updated somewhere or similar?

@ricsanfre
Copy link
Owner

Currently there is an issue, ansible-collections/community.docker#860, making ansible docker package not workig and so "molecule" workflows are broken. There is a molecule, PR ansible/molecule#4185 fixes this issue, so I won`t apply workarround in github actions to avoid installation of the broken package.

@ricsanfre ricsanfre merged commit 93bd848 into ricsanfre:master Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants