Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement valid character sets in Annex-B #62

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Implement valid character sets in Annex-B #62

merged 1 commit into from
Apr 25, 2023

Conversation

HalidOdat
Copy link
Collaborator

@HalidOdat HalidOdat commented Apr 23, 2023 •
edited
Loading

This adds the "annex-b" which enables EcmaScript's Annex-B RegExp syntax.

Regexes like [a-\s] and [--\d] are allowed in Annex-b and are not treated like a range, but with mach any char rule. This only applies in non-unicode mode.

@HalidOdat HalidOdat added the enhancement New feature or request label Apr 23, 2023
@HalidOdat HalidOdat mentioned this pull request Apr 23, 2023
Closed
@HalidOdat HalidOdat changed the title Fix valid character sets in Annex-B Implement valid character sets in Annex-B Apr 23, 2023
@ridiculousfish
Copy link
Owner

ridiculousfish commented Apr 24, 2023 •
edited
Loading

Thank you for this, the code changes look good. regress just considers Annex B to be active 100% of the time: literally nobody implements the non-Unicode ES spec without Annex B. Please remove the annex-b feature, treat it as true everywhere (should only affect non-Unicode paths!) and I'll be happy to merge.

ridiculousfish
ridiculousfish requested changes Apr 24, 2023
View reviewed changes
Copy link
Owner

@ridiculousfish ridiculousfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@ridiculousfish ridiculousfish merged commit dcc8ab6 into master Apr 25, 2023
@ridiculousfish
Copy link
Owner

Merged as dcc8ab6, thank you!!

@HalidOdat HalidOdat deleted the fix/valid-character-sets branch April 25, 2023 05:23
@HalidOdat
Copy link
Collaborator Author

Would it be possible to publish a new version ?

@ridiculousfish
Copy link
Owner

done, v0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridiculousfish ridiculousfish Awaiting requested review from ridiculousfish

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HalidOdat @ridiculousfish