Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Clock epoch_debug() , timestamp in micros #189

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mikelngelous
Copy link

In case there are multiple receptions from different services, it is a good idea to know when they arrive, even at the different layers, here is an example in the RouterContext

@riebl
Copy link
Owner

riebl commented May 12, 2023

I like your idea @mikelngelous, I am just not convinced that the string formatting should become a method of vanetza::Clock. Also, calling std::chrono::high_resolution_clock could be quite confusing in the end because "clock ticking" is solely handled by vanetza::Runtime everywhere else.

@mikelngelous
Copy link
Author

@riebl you are right. Now I've used runtime to get the timestamp. Do I have to make a new pull request ? also for new contributions like udp unicast that I've pushed

@riebl
Copy link
Owner

riebl commented May 21, 2023

Sorry for my late reply; I have been away for a few days. I prefer to have pull requests per feature, i.e. your UDP feature for socktap would be a separate pull request.
What is the reason that you have closed your PR @mikelngelous?

@mikelngelous mikelngelous reopened this May 26, 2023
@mikelngelous
Copy link
Author

It is reopened again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants