udp multicast ip #200
Open
udp multicast ip #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riebl
reviewed
Sep 25, 2023
| @@ -7,18 +7,28 @@ | |||
| namespace ip = boost::asio::ip; | |||
| using namespace vanetza; | |||
|
|
|||
| UdpLink::UdpLink(boost::asio::io_service& io_service, const ip::udp::endpoint& endpoint) : | |||
| UdpLink::UdpLink(boost::asio::io_service& io_service, const ip::udp::endpoint& endpoint, const std::string& ip) : | |||
There was a problem hiding this comment.
passing address as boost::asio::ip::address might be beneficial
| multicast_endpoint_(endpoint), | ||
| tx_socket_(io_service), rx_socket_(io_service), | ||
| rx_buffer_(2560, 0x00) | ||
| { | ||
| tx_socket_.open(multicast_endpoint_.protocol()); | ||
|
|
||
| if(ip.size() != 0){ | ||
| boost::asio::ip::multicast::outbound_interface option(boost::asio::ip::address_v4::from_string(ip)); |
There was a problem hiding this comment.
I just had a look at the ip(7) man page: I assume we can even pass the interface index instead of an IP address to outbound_interface and join_group. This would save us the EthernetDevice::ip lookup call.
There was a problem hiding this comment.
Interface index instead of IP seems reasonable, I can try it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific network interface (selected according its IP address) is used for UDP multicast.