Add CPM (TS102894-2v211) to Vanetza #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cam_functions.hpp.in
|
I will have a deeper look at it as soon as possible. But I can say already now: Thanks a lot for your effort! |
|
Sorry, I had no chance yet to review your PR carefully and I will be abroad for a week now. I have to postpone the review until my return. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @riebl,
This is a continuation of the old pull request i made. I deleted it by mistake when moving the code to another branch. I am sorry about the inconvenience.
This implementation already has the newly released CAM and the release 2 of DENM, besides the CPM.
To support either ITS release 1 or ITS release 2, i have changed the cmake recipe to support an option (VANETZA_ASN1_WITH_ITS2) that only links the selected version. The vanetza/asn1/its was renamed to vanetza/asn1/its1 and now the files of the selected release are copied into vanetza/asn1/its. There might be a more effiecient way to do it, let me know your thoughts.
A version of the asn1c proposed in this issue by @v0-e was used. This version supports the compilation of the release 2 asn1 files without any patching. The only small change i made was on the import CDD identification on both the CPM and DEMN to the CDDv2.2.1.
Finally some files, due to differences in the release 1 to release 2 specification, were changed in order to support both releases (like the cpm.hpp).
With that said, some files, like tests, still need to changed in order to fully support both releases.
Looking forward to receive some feedback.