Add support for a minimum TTL for events #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
force-pushed
the
add-minimum-ttl
branch
3 times, most recently
from
46a3a33 to
5f7bad0
Compare
smortex
dismissed
jamtur01’s stale review
The merge-base changed after approval.
smortex
dismissed
jamtur01’s stale review
The merge-base changed after approval.
Meh! I will rebase the branches on top of main, I hope this will help! |
When running with riemann-wrappers, one may want to run different tools with distinct ttl, but the `--ttl` flag cannot be specified twice, so the following configuration will not work: ``` --- options: --ttl 300 tools: - name: "health" - name: "rdap" options: "--interval 21600 --ttl 86400 --domains example.com example.net" ``` A workaround is to add an explicit ttl for each tool, but it is not convenient. Introduce a `--minimum-ttl` flag that can be used as a global option to circumvent this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with riemann-wrappers, one may want to run different tools with distinct ttl, but the
--ttlflag cannot be specified twice, so the following configuration where we want to run thehealthtool every 5 seconds (default value) but with a longer TTL than the default (twice the interval) will not work:A workaround is to add an explicit ttl for each tool, but it is not convenient.
Introduce a
--minimum-ttlflag that can be used as a global option to circumvent this issue: