Add support for ignoring IPs by ASN in riemann-http
#295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
force-pushed
the
filter-by-asn
branch
2 times, most recently
from
b3f2c84 to
ce01a18
Compare
smortex
dismissed
jamtur01’s stale review
The merge-base changed after approval.
Monitoring a website behind a Content Delivery Network (CDN) may lead to flapping metrics when the short-lived IP addresses where the service is accessible change. Allow to provide a list of Autonomous System Numbers (ASN) that we can ignore for well-known CDN service providers. Use the MaxMind ASN database provided by the user for IP lookups. This is not a hard dependency as no ASN filtering is done by default, so only add this dependency for testing and assume the end-user will handle the soft requirement on his own if they want to do filter-out some ASN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitoring a website behind a Content Delivery Network (CDN) may lead to
flapping metrics when the short-lived IP addresses where the service is
accessible change.
Allow to provide a list of Autonomous System Numbers (ASN) that we can
ignore for well-known CDN service providers. Use the MaxMind ASN
database provided by the user for IP lookups.
This is not a hard dependency as no ASN filtering is done by default, so
only add this dependency for testing and assume the end-user will handle
the soft requirement on his own if they want to do filter-out some ASN.