Fix some linter issues #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guenhter
force-pushed
the
fix-some-linter-issues
branch
from
b743e8e to
d8de71e
Compare
|
As you can see, i turned travis back on, it was changed somehow. I am also looking at the ansible galaxy thing, but boy did they screw that up. Docs wise i cannot find 1.2.3 on how to upload a new version. Would that not be the first thing you would document or at least mention in your new site ;) |
|
I'll tried to run the tests locally and for Linux they start to fail in a early stage. Should I have a look to fix the local tests? |
|
If possible. Should have enough credits on CI to do some tests. Presume some updates where made. Also the role update to galaxy seems broken.
Verzonden vanuit Outlook voor iOS<https://aka.ms/o0ukef>
…________________________________
Van: Günther Grill ***@***.***>
Verzonden: Monday, October 9, 2023 7:39:19 AM
Aan: riemers/ansible-gitlab-runner ***@***.***>
CC: Erik-jan Riemers ***@***.***>; Comment ***@***.***>
Onderwerp: Re: [riemers/ansible-gitlab-runner] Fix some linter issues (PR #286)
I'll tried to run the tests locally and for Linux they start to fail in a early stage. Should I have a look to fix the local tests?
—
Reply to this email directly, view it on GitHub<#286 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFGQOORJQ67NX5DJTQ3JE3X6OEYPAVCNFSM6AAAAAA5WZ7PZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGM3TGOBWG4>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Also don't forget to slap your name somewhere since i really appreciate the work. |
Closed
gardar
reviewed
Jan 22, 2024
| name: 'Close stale issues and PRs' | ||
| on: | ||
| name: Close stale issues and PRs | ||
| true: |
There was a problem hiding this comment.
This is not right and breaks the workflow
There was a problem hiding this comment.
Outch. Mabe we can fix this with one of the next pull requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This are just the linter issues which could be fixed automated by
ansible-lint --writebut I thought it is already worth creating a PR because this is already quite comprehensive.