Add runner registration with runner auth token #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support "--token" option: runner register --token glrt-XXXXXXXX New workflow https://docs.gitlab.com/ee/ci/runners/new_creation_workflow.html
|
This is exactly what i need! Thank you! |
5 tasks
guenhter
reviewed
Jul 6, 2024
README.md
Outdated
| - `gitlab_runner_registration_token` - The GitLab registration token. If this is specified, a runner will be registered to a GitLab server. | ||
| - `gitlab_runner_registration_token` - The GitLab registration token. If this is specified, each runner will be registered to a GitLab server. Deprecating in gitlab version 16.0 and removed in 18.0. | ||
| - `gitlab_runner_registration_token_type` - Gitlab runner registration token type | ||
| Set "runner-token" to register runner with --token option (new workflow https://docs.gitlab.com/ee/ci/runners/new_creation_workflow.html) |
There was a problem hiding this comment.
The wording in Gitlab is always
- Authentication Token (for the new workflow)
- Registration Token (for the old workflow)
I don't know if "runner-tokne" is also a common naming. I'd stick to the two mostely used in the gitlab documentation
There was a problem hiding this comment.
You are ringht, thanks! I renamed runner-token to authentication-token
|
Also made a first attempt to add this new process but then the PR was closed. Nevertheless, there are some very useful parts in there. I guess e.g. the --tags option is not working any more in the new registration process... |
|
Thx for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support "--token" option: runner register --token glrt-XXXXXXXX
New workflow https://docs.gitlab.com/ee/ci/runners/new_creation_workflow.html