Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitlab_runner_no_log_secrets to list of configured runners #340

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

tremlin
Copy link
Contributor

@tremlin tremlin commented Aug 5, 2024

When I used the role to deploy Gitlab runners with the new workflow (Gitlab runner version 17.2.1) I noticed that the step Create list of configured runners displayed the runner token despite the gitlab_runner_no_log_secrets option being set.

This PR adds the no_log option to this step to prevent the output of the runner token.

Example before patch:

TASK [riemers.gitlab-runner : Create list of configured runners] ***************************************************************************************
skipping: [terraform-ci] => (item={'arch': 'amd64', 'level': 'info', 'msg': 'Runtime platform', 'os': 'linux', 'pid': 15288, 'revision': '9882d9c7', 'time': '2024-08-02T08:56:14Z', 'version': '17.2.1'}) 
skipping: [terraform-ci] => (item={'ConfigFile': '/etc/gitlab-runner/config.toml', 'level': 'info', 'msg': 'Listing configured runners', 'time': '2024-08-02T08:56:14Z'}) 
ok: [terraform-ci] => (item={'Executor': 'docker', 'Token': 'glrt-NOTMYTOKEN', 'URL': 'https://xxx', 'level': 'info', 'msg': 'Terraform CI', 'time': '2024-08-02T08:56:14Z'})

Example after patch:

TASK [riemers.gitlab-runner : Create list of configured runners] ***************************************************************************************
skipping: [terraform-ci] => (item=None) 
skipping: [terraform-ci] => (item=None) 
ok: [terraform-ci] => (item=None)

@guenhter guenhter merged commit 68f5f8e into riemers:master Aug 5, 2024
@guenhter
Copy link
Collaborator

guenhter commented Aug 5, 2024

Thx for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants