docs: Clarify registration_token requirement #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx for this contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
this Merge Request aims to clarify the documentation regarding the use of the
gitlab_runner_registration_token. I initially understood the current wording,it is recommended to specify a token for each runneras a suggestion rather than a requirement. The clarification here highlights that specifying a token for each runner is required, not just recommended, whengitlab_runner_registration_token_typeis set toauthentication-token.An alternative proposal would be allowing the global gitlab_runner_registration_token to be used with the --token command by default in the same way it works with the --registration-token option. That would simplify the process for registering multiple runners, as in the current GitLab Release it is intended to reuse a single token to register multiple hosts grouped as a single runner.