Skip to content

Commit

Permalink
chore(warnings): Clean up warnings due to project.json
Browse files Browse the repository at this point in the history
Forgot to upgrade project.json for Playground and ReactNative.Tests, as well as miscellaneous warnings in comments.
  • Loading branch information
rozele committed Aug 2, 2016
1 parent 104aa49 commit 4501096
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion ReactWindows/Playground/project.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"dependencies": {
"Facebook.CSSLayout": "2.0.0-pre",
"Facebook.CSSLayout": "2.0.1-pre",
"Microsoft.ApplicationInsights": "1.0.0",
"Microsoft.ApplicationInsights.PersistenceChannel": "1.0.0",
"Microsoft.ApplicationInsights.WindowsApps": "1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion ReactWindows/ReactNative.Tests/project.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"dependencies": {
"Facebook.CSSLayout": "2.0.0-pre",
"Facebook.CSSLayout": "2.0.1-pre",
"Microsoft.NETCore.UniversalWindowsPlatform": "5.2.2"
},
"frameworks": {
Expand Down
4 changes: 2 additions & 2 deletions ReactWindows/ReactNative/Views/Text/ReactSpanShadowNode.cs
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ public override void UpdateInline(Inline inline)
/// <summary>
/// This method will be called by <see cref="UIManagerModule"/> once
/// per batch, before calculating layout. This will only be called for
/// nodes that are marked as updated with <see cref="MarkUpdated"/> or
/// require layout (i.e., marked with <see cref="dirty"/>).
/// nodes that are marked as updated with <see cref="ReactShadowNode.MarkUpdated"/> or
/// require layout (i.e., marked with <see cref="ReactShadowNode.dirty"/> ).
/// </summary>
public override void OnBeforeLayout()
{
Expand Down
2 changes: 1 addition & 1 deletion ReactWindows/ReactNative/Views/Text/ReactTextShadowNode.cs
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ private void UpdateTextBlockCore(RichTextBlock textBlock, bool measureOnly)
/// This method will be called by <see cref="UIManagerModule"/> once
/// per batch, before calculating layout. This will only be called for
/// nodes that are marked as updated with <see cref="MarkUpdated"/> or
/// require layout (i.e., marked with <see cref="dirty"/>).
/// require layout (i.e., marked with <see cref="ReactShadowNode.dirty"/>).
/// </summary>
public override void OnBeforeLayout()
{
Expand Down

0 comments on commit 4501096

Please sign in to comment.