Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Program.declarations should be empty after copy_everything_except_instructions() #1613

Closed
mhodson-rigetti opened this issue Jul 6, 2023 · 0 comments · Fixed by #1614
Closed

Program.declarations should be empty after copy_everything_except_instructions() #1613

mhodson-rigetti opened this issue Jul 6, 2023 · 0 comments · Fixed by #1614
Assignees
@mhodson-rigetti
Labels
bug 🐛 An issue that needs fixing.

Comments

@mhodson-rigetti
Copy link
Contributor

Issue Description

In #1611 we discovered that Program.declarations should be treated as a view on Program.instructions, else there can be inconsistencies that cause troubles with some workflows. The implementation of Program.copy_everything_except_instructions() does not preserve this- it copies declarations but not instructions. The declarations member should also not be copied.
@mhodson-rigetti mhodson-rigetti added the bug 🐛 An issue that needs fixing. label Jul 6, 2023
@mhodson-rigetti mhodson-rigetti self-assigned this Jul 6, 2023
@mhodson-rigetti mhodson-rigetti mentioned this issue Jul 6, 2023
Merged
8 tasks
@mhodson-rigetti mhodson-rigetti linked a pull request Jul 6, 2023 that will close this issue
1613 Program declarations should be empty after copy #1614
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhodson-rigetti mhodson-rigetti

Labels
bug 🐛 An issue that needs fixing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1613 Program declarations should be empty after copy rigetti/pyquil
1 participant
@mhodson-rigetti