Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1613 Program declarations should be empty after copy #1614

Merged

Conversation

mhodson-rigetti
Copy link
Contributor

Description

Closes #1613

Back-ported the single-line fix from the v4 branch, so we no longer copy declarations member. Made a new test for Program.copy_everything_except_instructions() which was lacking; based this on the v4 test.

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@MarquessV MarquessV merged commit 839663e into master Jul 7, 2023
11 checks passed
@MarquessV MarquessV deleted the 1613-program-declarations-should-be-empty-after-copy branch July 7, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Program.declarations should be empty after copy_everything_except_instructions()
2 participants