1616 v4 catch up with v3 #1617
Merged
1616 v4 catch up with v3 #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarquessV
commented
Jul 13, 2023
There was a problem hiding this comment.
I removed this, as we don't have any current plans to add a compatibility module. I can re-instate it if we decide we need it.
MarquessV
commented
Jul 13, 2023
| @@ -146,7 +146,7 @@ def __init__( | |||
| execution_options_builder = ExecutionOptionsBuilder() | |||
| execution_options_builder.connection_strategy = ConnectionStrategy.default() | |||
| if endpoint_id is not None: | |||
| execution_options_builder.connection_strategy(ConnectionStrategy.endpoint_id(endpoint_id)) | |||
| execution_options_builder.connection_strategy = ConnectionStrategy.endpoint_id(endpoint_id) | |||
There was a problem hiding this comment.
squashing a pre-existing bug
MarquessV
commented
Jul 13, 2023
| ) | ||
| program = program.copy_everything_except_instructions() | ||
| assert len(program.instructions) == 0 # the purpose of copy_everything_except_instructions() | ||
| assert len(program.declarations) == 0 # this is a view on the instructions member; must be consistent |
kalzoo
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not many changes, despite how gnarly the conflicts were.