Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1611 Regression fix for Program.copy_everything_except_instructions() #1612

Merged
merged 3 commits into from
Jul 6, 2023
Merged

1611 Regression fix for Program.copy_everything_except_instructions() #1612

merged 3 commits into from
Jul 6, 2023

Commits on Jul 6, 2023

  1. Reverse RC23 change set (code only, not the test).

    @mhodson-rigetti
    mhodson-rigetti committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    7747272 View commit details
    Browse the repository at this point in the history

  2. Fix: Program.declarations is a view on Program.instructions and shoul… 

    …d not be copied.

This alternate solution makes the test that was developed for #1596 pass, where previously it failed. This should resolve both #1596 and #1611.
    @mhodson-rigetti
    mhodson-rigetti committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1e74d82 View commit details
    Browse the repository at this point in the history

  3. Fix: the shallow copy() method needs to copy the declarations

    @mhodson-rigetti
    mhodson-rigetti committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    4d9a234 View commit details
    Browse the repository at this point in the history