Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add memory_values to QPUResultData #393

Merged
merged 13 commits into from
Nov 28, 2023
Merged

feat: Add memory_values to QPUResultData #393

merged 13 commits into from
Nov 28, 2023

Conversation

MarquessV
Copy link
Contributor

closes #392

@MarquessV MarquessV linked an issue Nov 15, 2023 that may be closed by this pull request
QPUResultData should include the memory_values returned from a job execution result. #392
Closed
@MarquessV MarquessV marked this pull request as ready for review November 27, 2023 17:20
@MarquessV MarquessV mentioned this pull request Nov 27, 2023
Merged
kalzoo
kalzoo requested changes Nov 28, 2023
View reviewed changes
crates/lib/src/qpu/result_data.rs Outdated Show resolved Hide resolved
crates/python/src/qpu/api.rs Outdated Show resolved Hide resolved
crates/lib/src/execution_data.rs Outdated Show resolved Hide resolved
Shadow53
Shadow53 reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Shadow53 Shadow53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just confused about using HashMap<String, Option<_>>.

crates/python/src/qpu/api.rs Outdated Show resolved Hide resolved
crates/python/src/qpu/api.rs Outdated Show resolved Hide resolved
kalzoo
kalzoo approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@kalzoo kalzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@MarquessV MarquessV merged commit 0181c1b into main Nov 28, 2023
1 check passed
@MarquessV MarquessV deleted the 392-qpuresultdata-should-include-the-memory_values-returned-from-a-job-execution-result branch November 28, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadow53 Shadow53 Shadow53 left review comments

@kalzoo kalzoo kalzoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QPUResultData should include the memory_values returned from a job execution result.
3 participants
@MarquessV @Shadow53 @kalzoo