Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove all code related to arithmetic rewriting #480

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

kalzoo
Copy link
Contributor

@kalzoo kalzoo commented Jun 21, 2024

Clean removal of all arithmetic rewriting code.

Breaking change, of course; several public modules, structs, and functions removed from both rust and python packages.

Copy link

github-actions bot commented Jun 21, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://rigetti.github.io/qcs-sdk-rust/pr-preview/pr-480/
on branch qcs-sdk-python-docs at 2024-06-24 16:16 UTC

Copy link
Contributor

@Shadow53 Shadow53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes need to be cleaned up in crates/lib/examples/execute.rs, but the module removal itself looks fine.

CI checks failed, btw.

crates/lib/examples/execute.rs Outdated Show resolved Hide resolved
crates/lib/examples/execute.rs Outdated Show resolved Hide resolved
@kalzoo kalzoo force-pushed the 479-remove-arithmetic-rewriting branch from 46124ba to d526631 Compare June 21, 2024 21:33
@kalzoo kalzoo merged commit 223c276 into main Jun 25, 2024
2 checks passed
@kalzoo kalzoo deleted the 479-remove-arithmetic-rewriting branch June 25, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants