Breaking: refine public API #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalzoo
force-pushed
the
1-refine-public-api
branch
from
107c449
to
9eacdea
Compare
genos
reviewed
Jul 9, 2021
| @@ -43,17 +43,6 @@ pub enum ErrorKind { | |||
| actual: Token, | |||
| expected: String, | |||
| }, | |||
| /// An unknown identifier was encountered | |||
There was a problem hiding this comment.
Deleting code is such a pleasing feeling 😄
genos
reviewed
Jul 9, 2021
src/program/graph.rs
Outdated
| UncalibratedInstruction, | ||
| UnscheduleableInstruction, | ||
| UnscheduableInstruction, |
There was a problem hiding this comment.
Typo: "Unscheduable" is probably "Unschedu l able"
kalzoo
force-pushed
the
1-refine-public-api
branch
from
9eacdea
to
981679e
Compare
kalzoo
force-pushed
the
1-refine-public-api
branch
from
981679e
to
ab65d85
Compare
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Jul 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the number of visible functions and type definitions to those reasonably needed for outside use. Notably, this means removing public visibility for raw parsing and lexing functions, while leaving access to useful constructs like
Program,ScheduledProgram, and allInstructionmembers and variants.