new(rs): fully by-hand expression simplification #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 25, 2023 16:14
genos
changed the title
added 8 commits
August 31, 2023 13:21
|
Using our
|
|
A plot is worth 1k words
|
|
Oh, and the |
mac01021
reviewed
Aug 31, 2023
mac01021
reviewed
Sep 1, 2023
Shadow53
requested changes
Sep 5, 2023
mac01021
reviewed
Sep 7, 2023
mac01021
reviewed
Sep 7, 2023
mac01021
reviewed
Sep 7, 2023
Shadow53
requested changes
Sep 8, 2023
| ); | ||
| let new = simplify_infix( | ||
| multiplier, | ||
| // Addition associative, right: a + (b + c) = (a + b) + c, pick the shorter |
There was a problem hiding this comment.
Could merge this with the next case
There was a problem hiding this comment.
Same comment as before re: reconstructing the original
| min_by_key(original, new, size) | ||
| } | ||
|
|
||
| // Multiplication associative, right: a * (b * c) = (a * b) * c, pick the shorter |
There was a problem hiding this comment.
Could merge with the next case
There was a problem hiding this comment.
Same comment as before re: reconstructing the original
| min_by_key(original, new, size) | ||
| } | ||
|
|
||
| // Subtraction "associative" (not really), right: a - (b - c) = (a + c) - b |
There was a problem hiding this comment.
Could merge with the below case
There was a problem hiding this comment.
Same comment as before re: reconstructing the original
| min_by_key(original, new, size) | ||
| } | ||
|
|
||
| // Right distribution: a * (b + c) = (a * b) + (a * c) |
There was a problem hiding this comment.
Could merge with the next case, I think
There was a problem hiding this comment.
Same comment as before re: reconstructing the original
kalzoo
reviewed
Sep 11, 2023
kalzoo
approved these changes
Sep 13, 2023
This was referenced Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the work in #267 and #272; putting together multiple passes ofby_hand(by_egg(expression))yields dramatically simpler results.cargo test --releaseon the big expression in #259 yieldedwhich looks pretty darn close.This is just a proof of concept right now. Paying for multiple roundtrips to & from a formategglikes is inefficient.This now relies solely on by-hand simplification, and does rather well:
affine, expectingax + b + cx + dto simplify to(a + c)x + (b + d), I can't quite get around a syntax error in trying to cover this case;The by-hand simplification has a maximum limit of times it's allowed to run, to avoid some "test
XXXhas overflowed its stack" issues stemming from infinite recursions.