fix: use internal QuotedString wrapper to quote Quil strings correctly #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the clear writeup and the fix with a test! |
kalzoo
approved these changes
Nov 23, 2023
BatmanAoD
reviewed
Nov 23, 2023
Comment on lines
+330
to
+336
| for c in self.0.as_ref().chars() { | ||
| match c { | ||
| '"' => write!(f, "\\\"")?, | ||
| '\\' => write!(f, "\\\\")?, | ||
| c => write!(f, "{}", c)?, | ||
| } | ||
| } |
There was a problem hiding this comment.
I suspect String::replace would be faster than this, but we'd need to benchmark it. I don't know how much the performance of this conversion matters, though.
There was a problem hiding this comment.
This is specifically inside of Display, so I think this might actually be faster. String::replace would be creating a new owned String and then calling its Display, which probably looks similar to this loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #315.
This uses a new
QuotedStringwrapper with a customDisplayimpl to only escape quotation marks and backslashes in strings, and nothing else.