-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Program.wrap_in_loop()
method
#321
feat: Add Program.wrap_in_loop()
method
#321
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, aside from the thought about placeholders in the comment.
quil-rs/src/program/snapshots/quil_rs__program__tests__wrap_in_loop.snap
Outdated
Show resolved
Hide resolved
source: quil-rs/src/program/mod.rs | ||
expression: program.to_quil().unwrap() | ||
--- | ||
DECLARE ro BIT[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An idea for the future: we could use libquil-sys
to validate the behaviour of stuff like this, rather than eye-balling the logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
closes #320