Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Program.wrap_in_loop() method #321

Conversation

MarquessV
Copy link
Contributor

closes #320

Copy link

github-actions bot commented Dec 13, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://rigetti.github.io/quil-rs/pr-preview/pr-321/
on branch quil-py-docs at 2023-12-14 20:08 UTC

quil-py/quil/program/__init__.pyi Outdated Show resolved Hide resolved
quil-rs/src/program/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@kalzoo kalzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, aside from the thought about placeholders in the comment.

quil-rs/src/program/mod.rs Outdated Show resolved Hide resolved
quil-rs/src/program/mod.rs Outdated Show resolved Hide resolved
source: quil-rs/src/program/mod.rs
expression: program.to_quil().unwrap()
---
DECLARE ro BIT[1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An idea for the future: we could use libquil-sys to validate the behaviour of stuff like this, rather than eye-balling the logic.

Copy link
Contributor

@notmgsk notmgsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@MarquessV MarquessV merged commit fce7acc into main Dec 14, 2023
14 checks passed
@MarquessV MarquessV deleted the 320-add-method-to-program-that-will-wrap-it-in-a-quil-based-num-shots-loop branch December 14, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add method to Program that will wrap it in a Quil based num-shots loop
4 participants