fix: #337: use 'ryu' instead of 'lexical' for formatting #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BatmanAoD
changed the title
BatmanAoD
commented
Aug 9, 2024
| if value.im > 0f64 { | ||
| out.push('+') | ||
| let mut out = ryu::Buffer::new().format(value.re).to_owned(); | ||
| match value.im { |
There was a problem hiding this comment.
I don't mind going back to the else if/else here, but this seems slightly nicer to me, personally.
|
BatmanAoD
force-pushed
the
337-remove-lexical
branch
2 times, most recently
from
14e0be8
to
fddc14a
Compare
BatmanAoD
force-pushed
the
337-remove-lexical
branch
from
fddc14a
to
ddb227e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337
Looks like
ryualways prints a trailing.0for integers values.