Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: correctly compute duration for erfsquare waveform templates #406

Merged
merged 6 commits into from
Sep 30, 2024
Merged

fix!: correctly compute duration for erfsquare waveform templates #406

merged 6 commits into from
Sep 30, 2024

Commits on Sep 20, 2024

  1. test: add failing test of erfsquare durations

    @antalsz
    antalsz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2971993 View commit details
    Browse the repository at this point in the history

  2. fix: fix computation of duration for erfsquare waveform templates 

    The duration of an `erf_square` waveform is the sum of its duration *and* of its
left and right padding.
    @antalsz
    antalsz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8aa4e46 View commit details
    Browse the repository at this point in the history

  3. feat: support underscores in erfsquare, padleft, and padright 

    This is only relevant when computing durations
    @antalsz
    antalsz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    491ac48 View commit details
    Browse the repository at this point in the history

  4. test: fix test cases that assume erf_square only needs duration

    @antalsz
    antalsz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a3deee2 View commit details
    Browse the repository at this point in the history

  5. test: add pad_* parameters for erf_square to quil-py test cases

    @antalsz
    antalsz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0e5bb8c View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. feat: check for pad_left and pad_right on all waveforms, include … 

    …`_` in `erf_square`
    @antalsz
    antalsz committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6df2e21 View commit details
    Browse the repository at this point in the history