Update: parse ternary, binary, and unary logic

[nilslice]

Parses:

EQ dest ro 0
LT dest ro[1] -1
LE dest ro 1.2
GT dest ro[2] 1e-6
GE dest ro x
AND ro ro[1]
IOR ro[1] ro[2]
XOR ro[1] ro
NOT ro
NEG ro[1]

TODO:

• Update: parse ternary, binary, and unary logic #58 (comment)
• Update: parse ternary, binary, and unary logic #58 (review)
• Update: parse ternary, binary, and unary logic #58 (review)
• Update: parse ternary, binary, and unary logic #58 (comment)

[nilslice]

Account for https://github.com/quil-lang/quil/blob/master/grammars/Quil.g4#L172-L178

[genos]

A great start! Looking forward to seeing where this goes.

[notmgsk]

Aside from the clean up needed (commented code, TODOs) and removing the deprecated instructions, LGTM!

I'll defer approval until it's no longer marked draft.

[nilslice]

Also added unary logic parsing, but omitted the deprecated TRUE and FALSE operations. Will update this PR accordingly once the final decision is made re: deprecated OR binary operation.

[kalzoo]

Small Q / fix - but otherwise lgtm 👍

[nilslice]

@notmgsk @kalzoo - I've merged #60 into this branch, which adds support for ternary logic operations. Would appreciate a review when you have a moment. If you want to look at only the new ternary support, you can see a clean diff in #60.

[nilslice]

Another note, more generally speaking, open to renaming things like TernaryOperator to ComparisonOperator or similar. The grouping of these follows the Quil spec, but the naming is a bit more broad. For example, a LOAD is also ternary but is separated out on its own.

[kalzoo]

Aside from the possible naming change (and a fmt), looks great!

[genos]

LGTM! 👍

[kalzoo]

Looks good, thanks!

[github-actions]

🎉 This PR is included in version 0.10.3 🎉

The release is available on:

• crate.io packages (1 packages published)
• GitHub release

Your semantic-release bot 📦🚀