chore: convert terminate_working_block macro to fn #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalzoo
approved these changes
Jun 6, 2022
|
|
||
| ## Testing | ||
|
|
||
| When testing this crate, you should run with the `--all-features` flag to ensure all tests are executed. |
genos
reviewed
Jun 7, 2022
|
|
||
| ## Testing | ||
|
|
||
| When testing this crate, you should run with the `--all-features` flag to ensure all tests are executed. |
nilslice
commented
Jun 7, 2022
nilslice
commented
Jun 7, 2022
kalzoo
reviewed
Jun 8, 2022
Co-authored-by: Kalan <22137047+kalzoo@users.noreply.github.com>
|
🎉 This PR is included in version 0.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building up some more familiarity with #75, this was easier to follow w/ language server help. I think this function is pretty well covered in other tests, which would have caught issues, but that's an area I could look into more.
PR branch targets and is based on
75-frame-dependencies.UPDATE: forgot to test with
--all-featureslocally.