Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert terminate_working_block macro to fn #79

Merged
merged 11 commits into from
Jun 9, 2022

Conversation

nilslice
Copy link
Contributor

@nilslice nilslice commented Jun 6, 2022

While building up some more familiarity with #75, this was easier to follow w/ language server help. I think this function is pretty well covered in other tests, which would have caught issues, but that's an area I could look into more.

PR branch targets and is based on 75-frame-dependencies.

UPDATE: forgot to test with --all-features locally.

@nilslice nilslice requested a review from kalzoo June 6, 2022 21:45
Copy link
Contributor

@kalzoo kalzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, thank you 🙏


## Testing

When testing this crate, you should run with the `--all-features` flag to ensure all tests are executed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

@genos genos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A question for my own edification, some few ignorable suggestions, but LGTM.


## Testing

When testing this crate, you should run with the `--all-features` flag to ensure all tests are executed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

src/program/graph.rs Show resolved Hide resolved
src/program/graph.rs Outdated Show resolved Hide resolved
src/program/graph.rs Outdated Show resolved Hide resolved
src/program/graph.rs Outdated Show resolved Hide resolved
Base automatically changed from 75-frame-dependencies to main June 8, 2022 18:41
src/program/graph.rs Outdated Show resolved Hide resolved
nilslice and others added 2 commits June 8, 2022 21:44
Co-authored-by: Kalan <22137047+kalzoo@users.noreply.github.com>
@nilslice nilslice merged commit 618aa5e into main Jun 9, 2022
@nilslice nilslice deleted the sm/75-frame-dependencies branch June 9, 2022 19:47
@github-actions
Copy link

🎉 This PR is included in version 0.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants