Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly report timeout in errors #144

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Correctly report timeout in errors #144

merged 1 commit into from
Dec 14, 2020

Conversation

notmgsk
Copy link
Contributor

@notmgsk notmgsk commented Dec 11, 2020

Due to a scoping issue, timeouts were reported with the server's
timeout, rather than the client's (if it was provided).

Due to a scoping issue, timeouts were reported with the server's
timeout, rather than the client's (if it was provided).
@notmgsk notmgsk requested a review from a team as a code owner December 11, 2020 15:14
@erichulburd
Copy link

What do you mean by report? This effectively shortens the timeout for apply-handler if the client timeout < server timeout right?

@erichulburd erichulburd self-requested a review December 11, 2020 18:00
@notmgsk
Copy link
Contributor Author

notmgsk commented Dec 14, 2020

What do you mean by report? This effectively shortens the timeout for apply-handler if the client timeout < server timeout right?

Yes, and that was the case prior to this PR. Unfortunately, prior to this PR, when a timeout was hit RPCQ would issue an error message that used the server's timeout rather than the client's timeout. So the client might see a misleading message (client provides a timeout but sees a different timeout in the error message).

@notmgsk notmgsk merged commit 0a5f25c into master Dec 14, 2020
@notmgsk notmgsk mentioned this pull request Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants