feat(runtime): better typing declarations in the patchEvent() feature

rigor789 · Mar 24, 2020 · b68f169 · b68f169
1 parent 1f2148a
commit b68f169
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/runtime/src/modules/events.ts b/packages/runtime/src/modules/events.ts
@@ -20,7 +20,7 @@ function addEventListener(
   el: INSVElement,
   event: string,
   handler: EventListener,
-  options?: EventListenerOptions
+  options: EventListenerOptions = {}
 ) {
   el.addEventListener(event, handler, options)
 }

diff --git a/packages/runtime/src/nodes.ts b/packages/runtime/src/nodes.ts
@@ -50,7 +50,11 @@ export interface INSVElement extends INSVNode {
   meta: NSVViewMeta
   style: Style | string
 
-  addEventListener(event: string, handler: any, options?: any): void
+  addEventListener(
+    event: string,
+    handler: any,
+    options: AddEventListenerOptions
+  ): void
 
   removeEventListener(event: string, handler?: any): void
 
@@ -138,7 +142,11 @@ export class NSVElement extends NSVNode implements INSVElement {
     return (this._meta = getViewMeta(this.tagName))
   }
 
-  addEventListener(event: string, handler: any, options: any = {}) {
+  addEventListener(
+    event: string,
+    handler: any,
+    options: AddEventListenerOptions = {}
+  ) {
     const { capture, once } = options
     if (capture) {
       console.log('Bubble propagation is not supported')