Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(riklet): use firepilot binary autoload #123

Merged
merged 6 commits into from
May 11, 2023
Merged

chore(riklet): use firepilot binary autoload #123

merged 6 commits into from
May 11, 2023

Conversation

MaloPolese
Copy link
Member

@MaloPolese MaloPolese commented May 9, 2023 •
edited
Loading

Closes #114

📑 Description

  • use firepilot ability to locate the firecracker binary instead of having to specify the binary location in arguments (see docs)
  • Document the ability to configure firecracker binary through environment variable in the project documentation

✅ Checks

  • My pull request adheres to the code style of this project
  • My code is documented
  • I provided unitary tests or procedure to test my code
  • My PR have a clear description of what my code is supposed to do

ℹ Additional Information

@MaloPolese MaloPolese linked an issue May 9, 2023 that may be closed by this pull request
Use firepilot binary autoload #114
Closed
@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label May 9, 2023
@MaloPolese MaloPolese self-assigned this May 9, 2023
@MaloPolese MaloPolese marked this pull request as ready for review May 9, 2023 18:16
@MaloPolese MaloPolese requested a review from a team as a code owner May 9, 2023 18:16
@alexandrebrg alexandrebrg changed the title 114 use firepilot binary autoload chore(riklet): use firepilot binary autoload May 10, 2023
alexandrebrg
alexandrebrg requested changes May 10, 2023
View reviewed changes
Copy link
Member

@alexandrebrg alexandrebrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, a little bit of documentation and we'll be all set!

riklet/src/runtime/function_runtime.rs Show resolved Hide resolved
@MaloPolese MaloPolese force-pushed the 114-use-firepilot-binary-autoload branch from 1c171aa to e2b5b55 Compare May 10, 2023 18:24
@github-actions github-actions bot added the type/enhancement New feature or request label May 10, 2023
@alexandrebrg alexandrebrg removed the type/documentation Improvements or additions to documentation label May 11, 2023
@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label May 11, 2023
@MaloPolese
feat(riklet): use FirecrackerExecutorBuilder::auto() function
e799aa6 
Signed-off-by: Malo Polese <malo.polese@gmail.com>
@MaloPolese
feat(riklet): remove riklet cli firecracker_location option
f156a67 
Signed-off-by: Malo Polese <malo.polese@gmail.com>
@MaloPolese
docs(riklet): remove --firecracker-path option in README
99c39a2 
Signed-off-by: Malo Polese <malo.polese@gmail.com>
@MaloPolese
docs(riklet): add riklet documentation
8e991f2 
Signed-off-by: Malo Polese <malo.polese@gmail.com>
@MaloPolese
docs(riklet): typo and remove unused cli param
c478c54 
Signed-off-by: Malo Polese <malo.polese@gmail.com>
@MaloPolese
docs(riklet): add more details about the usage of env vars
953e56d 
Signed-off-by: Malo Polese <malo.polese@gmail.com>
@MaloPolese MaloPolese force-pushed the 114-use-firepilot-binary-autoload branch from b892554 to 953e56d Compare May 11, 2023 17:50
@MaloPolese MaloPolese merged commit c8369b3 into main May 11, 2023
@MaloPolese MaloPolese deleted the 114-use-firepilot-binary-autoload branch May 11, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebrg alexandrebrg alexandrebrg approved these changes

@kalil-pelissier kalil-pelissier Awaiting requested review from kalil-pelissier

Assignees

@MaloPolese MaloPolese

Labels
type/documentation Improvements or additions to documentation type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use firepilot binary autoload
2 participants
@MaloPolese @alexandrebrg