Apply Pedantic recommendations #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guilhermecaldas
commented
Dec 23, 2019
guilhermecaldas
commented
- Applied most health suggestions from https://pub.dev/packages/socket_io#-analysis-tab- using on Pedantic code analysis (except 3 recommended fixes, to avoid logic changes)
- Code has passed by tests
- All code change commits include the rule in which they were based
Following the guideline: "Don't access members with this unless avoiding shadowing"
Following the guideline: "Annotate overridden members"
Following the guideline: "Prefer single quotes where they won't require escape sequences"
Following the guideline: "Don't type annotate initializing formals"
Following the guideline: "Try adding a return type to the method"
Following the guideline: "Omit type annotations for local variables"
Following the guideline: "Use generic function type syntax for parameters"
Following the guideline: "DO use curly braces for all flow control structures"
Following guideline: "Use contains instead of indexOf"
Following the guideline: "Use isNotEmpty instead of length" and "Use `isNotEmpty` for Iterables and Maps"
Following the guidelines: "Private field could be final"
Following the guidelines: "Use collection literals when possible"
Following the guidelines: - Avoid const keyword - Use adjacent strings to concatenate string literals - Don't explicitly initialize variables to null - Prefer using if null operators - Avoid empty catch blocks - Prefer using `??=` over testing for null
Code formatted automatically using "dartfmt --fix -w ."
|
@guilhermecaldas Thanks for the contribution. |
jumperchen
added a commit
that referenced
this pull request
Dec 27, 2019
jumperchen
added a commit
that referenced
this pull request
Dec 27, 2019
jumperchen
added a commit
that referenced
this pull request
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.