Fix: Add label for empty string in column header (#4067)

* Add label for empty string in column header * Handle empty string for row values * Use NSBP character
rilldata · Feb 16, 2024 · 6a13701 · 6a13701 · github-actions · Feb 16, 2024
1 parent 700f488
commit 6a13701
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/web-common/src/features/dashboards/pivot/PivotExpandableCell.svelte b/web-common/src/features/dashboards/pivot/PivotExpandableCell.svelte
@@ -22,7 +22,14 @@
       </div>
     </button>
   {/if}
-  {value === "LOADING_CELL" ? "" : value}
+
+  {#if value === "LOADING_CELL"}
+    {""}
+  {:else if value === ""}
+    {"\u00A0"}
+  {:else}
+    {value}
+  {/if}
 </div>
 
 <style lang="postcss">

diff --git a/web-common/src/features/dashboards/pivot/pivot-column-definition.ts b/web-common/src/features/dashboards/pivot/pivot-column-definition.ts
@@ -96,6 +96,10 @@ function createColumnDefinitionForDimensions(
           [dimensionNames[level]]: value,
         });
 
+        if (displayValue === "") {
+          displayValue = "\u00A0";
+        }
+
         return {
           header: displayValue,
           columns: nestedColumns,