Added PropertiesFromVariables to connector hash (#5012)

runtime/reconcilers/connector.go

@@ -125,5 +125,24 @@ func (r *ConnectorReconciler) executionSpecHash(spec *runtimev1.ConnectorSpec) (
 		}
 	}
 
+	// sort propertiesFromVariables by key
+	keys = make([]string, 0, len(spec.PropertiesFromVariables))
+	for k := range spec.PropertiesFromVariables {
+		keys = append(keys, k)
+	}
+	sort.Strings(keys)
+
+	// write propertiesFromVariables to hash
+	for _, k := range keys {
+		_, err = hash.Write([]byte(k))
+		if err != nil {
+			return "", err
+		}
+		_, err = hash.Write([]byte(spec.PropertiesFromVariables[k]))
+		if err != nil {
+			return "", err
+		}
+	}
+
 	return hex.EncodeToString(hash.Sum(nil)), nil
 }

runtime/runtime.go

@@ -190,9 +190,10 @@ func (r *Runtime) UpdateInstanceConnector(ctx context.Context, instanceID, name
 
 	// append the new/updated connector
 	inst.ProjectConnectors = append(inst.ProjectConnectors, &runtimev1.Connector{
-		Name:   name,
-		Type:   connector.Driver,
-		Config: connector.Properties,
+		Name:                name,
+		Type:                connector.Driver,
+		Config:              connector.Properties,
+		ConfigFromVariables: connector.PropertiesFromVariables,
 	})
 
 	return r.EditInstance(ctx, inst, false)

runtime/server/connectors.go

@@ -57,7 +57,11 @@ func (s *Server) AnalyzeConnectors(ctx context.Context, req *runtimev1.AnalyzeCo
 
 		cfg, err := s.runtime.ConnectorConfig(ctx, req.InstanceId, connector.Name)
 		if err != nil {
-			return nil, err
+			res[connector.Name] = &runtimev1.AnalyzedConnector{
+				Name:         connector.Name,
+				ErrorMessage: err.Error(),
+			}
+			continue
 		}
 
 		c := &runtimev1.AnalyzedConnector{