Runtime: fixes panic in ValidateMetricsView (#4241)

rilldata · Mar 5, 2024 · 8b0cfc4 · 8b0cfc4
1 parent eb5aa24
commit 8b0cfc4
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/runtime/validate.go b/runtime/validate.go
@@ -80,8 +80,7 @@ func (r *Runtime) ValidateMetricsView(ctx context.Context, instanceID string, mv
 		f, ok := fields[strings.ToLower(mv.TimeDimension)]
 		if !ok {
 			res.TimeDimensionErr = fmt.Errorf("timeseries %q is not a column in table %q", mv.TimeDimension, mv.Table)
-		}
-		if f.Type.Code != runtimev1.Type_CODE_TIMESTAMP && f.Type.Code != runtimev1.Type_CODE_DATE {
+		} else if f.Type.Code != runtimev1.Type_CODE_TIMESTAMP && f.Type.Code != runtimev1.Type_CODE_DATE {
 			res.TimeDimensionErr = fmt.Errorf("timeseries %q is not a TIMESTAMP column", mv.TimeDimension)
 		}
 	}