Fix search for Custom Dashboards (#5668)

rilldata · Sep 12, 2024 · c628b2c · c628b2c · github-actions · Sep 12, 2024
1 parent ba2a82e
commit c628b2c
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/web-admin/src/features/dashboards/listing/DashboardsTable.svelte b/web-admin/src/features/dashboards/listing/DashboardsTable.svelte
@@ -58,8 +58,13 @@
     },
     {
       id: "title",
-      accessorFn: (row: DashboardResource) =>
-        row.resource.metricsView.spec.title,
+      accessorFn: (row: DashboardResource) => {
+        const resource = row.resource;
+        const isMetricsExplorer = !!resource?.metricsView;
+        return isMetricsExplorer
+          ? resource.metricsView.spec.title
+          : resource.dashboard.spec.title;
+      },
     },
     {
       id: "name",
@@ -71,8 +76,11 @@
     },
     {
       id: "description",
-      accessorFn: (row: DashboardResource) =>
-        row.resource.metricsView.spec.description,
+      accessorFn: (row: DashboardResource) => {
+        const resource = row.resource;
+        const isMetricsExplorer = !!resource?.metricsView;
+        return isMetricsExplorer ? resource.metricsView.spec.description : "";
+      },
     },
   ];