Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError in Time Dimension Details crashes the app #3989

Closed
ericpgreen2 opened this issue Feb 8, 2024 · 3 comments
Closed

TypeError in Time Dimension Details crashes the app #3989

ericpgreen2 opened this issue Feb 8, 2024 · 3 comments
Assignees
Labels
Type:Bug Something isn't working

Comments

@ericpgreen2
Copy link
Contributor

image
@ericpgreen2 ericpgreen2 added the Type:Bug Something isn't working label Feb 8, 2024
@bcolloran
Copy link
Contributor

part of #3679

@bcolloran
Copy link
Contributor

the crash is in transposeArray:

export function transposeArray(arr, rowCount, columnCount) {
  const columnarBody = [];

  for (let i = 0; i < columnCount; i++) {
    const column = [];
    for (let j = 0; j < rowCount; j++) {
      column.push(arr[j][i]);   // ------------- CRASHES HERE------------------
    }
    columnarBody.push(column);
  }

  return columnarBody;
}

there is a stop gap solution in #4135, but @djbarnwal will need to do type cleanups in the surrounding files to get a more robust behavior. Reassigning to @djbarnwal for a complete fix.

@bcolloran bcolloran assigned djbarnwal and unassigned bcolloran Feb 21, 2024
@bcolloran
Copy link
Contributor

possibly closed by #4042 and @djbarnwal has additional work that might help in #4154. Going to close this since we can't directly reproduce, can always re-open if this error code shows up in telemetry again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants