Stricter types for Time dimension detail table #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcolloran
suggested changes
Feb 23, 2024
There was a problem hiding this comment.
Nice work @djbarnwal. My main comment overall is: be careful of casting. If you find yourself doing it very much it means something is wrong and you should look into the upstream types you are working with and wrap them so that the need to cast doesn't flow into your downstream code.
For us, our API types are annoying limited, which means types don't flow through the system as easily as we'd like, but rather than casting at the endpoint, you should use type guards and wrappers as close to the data ingestion point as possible.
web-common/src/features/dashboards/time-series/timeseries-data-store.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/dashboards/time-dimension-details/time-dimension-data-store.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds stricter types for Time dimension detail table. There are still some type warnings but we need better runtime support for some types.
For ex- values in
V1MetricsViewAggregationResponseDataItemshould not be typed asany