Release cloud-admin to netlify when tag #2057
Conversation
himadrisingh
changed the title
.github/workflows/cloud-admin.yml
Outdated
| paths: | ||
| - ".github/workflows/cloud-admin.yml" | ||
| - "web-admin/**" | ||
| - "web-local/**" |
There was a problem hiding this comment.
Any reason for web-local to be included here?
There was a problem hiding this comment.
oh it should have been common
.github/workflows/cloud-admin.yml
Outdated
| - name: Set up NodeJS | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18 |
There was a problem hiding this comment.
I'm not sure if this is a problem or not, but I think the Applications team has all been on Node 16. (We should probably upgrade as mentioned here)
There was a problem hiding this comment.
we have node 16 in the tests too
https://github.com/rilldata/rill-developer/blob/main/.github/workflows/web-test.yml#L31-L34
will move all to 16 then
.github/workflows/cloud-admin.yml
Outdated
| npm install | ||
| npm run build -w web-admin | ||
|
|
||
| - name: Deploy ${{ matrix.name }} to Netlify Staging |
There was a problem hiding this comment.
Why matrix.name here? I don't see a matrix build
There was a problem hiding this comment.
copy paste error 🤦
| tags: | ||
| - "*" | ||
| branches: ["main"] | ||
| paths: |
There was a problem hiding this comment.
I don't think we need paths here – any tag on main can just trigger a build.
If you want to keep the paths – we also need to add web-common here
and release to prod