Pivot table prototype #3694
Merged
Pivot table prototype #3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* preliminary table styling update * adjustment to table height * hide drag area outline
✅ Deploy Preview for rill-developer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* install d3-format types and fix typing for time grain access * typeguard in pivot config
briangregoryholmes
approved these changes
Feb 5, 2024
ericpgreen2
reviewed
Feb 5, 2024
Comment on lines
53
to
56
| timeStart: timeRange?.start | ||
| ? timeRange.start | ||
| : timeControls.timeStart, | ||
| timeEnd: timeRange?.end ? timeRange.end : timeControls.timeEnd, |
There was a problem hiding this comment.
Noting timeStart and timeEnd are deprecated now in favor of timeRange
ericpgreen2
reviewed
Feb 5, 2024
Comment on lines
+29
to
+30
| limit = "100", | ||
| offset = "0", |
There was a problem hiding this comment.
The type for these from orval is string. The swagger spec says it is string as well. Not sure if this is done intentionally.
ericpgreen2
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
#3934