Runtime: unified duckdb connector for motherduck and external db files
#3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-anshul
changed the title
duckdb and motherduckduckdb connector for motherduck and external db files
begelundmuller
requested changes
Dec 15, 2023
begelundmuller
approved these changes
Dec 15, 2023
mindspank
pushed a commit
that referenced
this pull request
Dec 18, 2023
…` files (#3700) * external duckdb and motherduck * adding test and lint fix * lint fix * formatting fix * formatting fix * lint fix * review comments - fix defer res.Close() * fix defer res.Close() in other places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3642