Allow resizing the height of the "Model Data" dashboard module in Rill Developer #3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
added
the
blocker
|
Approving as it's a blocker, but, after looking at how this works throughout our application, I'd like to propose a different approach for this and will do so in another PR. I've marked two nits for review. There's also some unintended cursor snapping behavior, but this should be addressed by my PR. |
briangregoryholmes
approved these changes
Jan 2, 2024
web-common/src/features/dashboards/rows-viewer/RowsViewerAccordion.svelte
Outdated
Show resolved
Hide resolved
Sounds good, feel free 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3744