Introduce backend flag to indicate that a deployed project is in an a… #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctual production state
begelundmuller
requested changes
Jan 2, 2024
There was a problem hiding this comment.
Change of plan – @nishantmonu51 requested to turn this into a generic tagging feature. High level suggested changes:
- Instead of
ProdSLA bool, we would haveProdTags []string - Instead of
rill sudo project search --sla, we would haverill sudo project search --tag tag1 --tag tag2 ...(usecmd.Flags().StringSliceVarto read multiple values into a[]string).
|
Nit: Instead of |
begelundmuller
requested changes
Jan 3, 2024
begelundmuller
requested changes
Jan 5, 2024
admin/database/database.go
Outdated
| ProdSlots int `db:"prod_slots"` | ||
| ProdTTLSeconds *int64 `db:"prod_ttl_seconds"` | ||
| ProdDeploymentID *string `db:"prod_deployment_id"` | ||
| Tags pq.StringArray `db:"tags"` |
There was a problem hiding this comment.
We don't use lib/pq, we use jackc/pgx for Postgres. Does this work? If yes, you can just put []string here. If not, should use pgtype.Array[string].
There was a problem hiding this comment.
I tried both ways you suggested, only works if we use pq.StringArray or custom impl of Tags
…d-flag-to-indicate-that-a-deployed-project-is-in-an-actual-production-state
begelundmuller
approved these changes
Jan 8, 2024
begelundmuller
deleted the
3648-introduce-backend-flag-to-indicate-that-a-deployed-project-is-in-an-actual-production-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.