-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add euro format #3850
Add euro format #3850
Conversation
// [789.1234686 / 100, "789.12%"], // ACTUALLY GETTING '789.1%' | ||
// [89.1234686 / 100, "89.12%"], // ACTUALLY GETTING '89.1%' | ||
// [9.1234686 / 100, "9.12%"], // ACTUALLY GETTING '9.1%' | ||
// [0.1234686 / 100, "0.12%"], // ACTUALLY GETTING '0.1%' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericpgreen2 -- note that this has been entirely disabled for months. I've commented out individual cases that are not working exactly as desired (though they are small edge cases that have not been bothersome in practice), but I reckon it's better to have most of the cases running and these ones commented out with FIXME than to turn off the whole file
@ericpgreen2 This PR adds a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @Fredehagelund92 for getting this started, and thanks @bcolloran for getting it over-the-line!
As @bcolloran and I discussed, this is a short-path to add the Euro. When adding many more currencies, we should think about a more scalable strategy/syntax.
continuing the work started by @Fredehagelund92 in PR #3748