Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CTA layout bug #3918

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Fix CTA layout bug #3918

merged 3 commits into from
Jan 29, 2024

Conversation

ericpgreen2
Copy link
Contributor

A previous PR caused us to lose the top margin on CTA pages. This PR further cleans up the Cloud layout to ensure aesthetic CTA pages.

Before:
image

After:
image

@ericpgreen2 ericpgreen2 added Type:Bug Something isn't working blocker A release blocker issue that should be resolved before a new release labels Jan 28, 2024
@ericpgreen2 ericpgreen2 self-assigned this Jan 28, 2024
bcolloran
bcolloran approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@bcolloran bcolloran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ericpgreen2 ericpgreen2 merged commit 321215e into main Jan 29, 2024
4 checks passed
@ericpgreen2 ericpgreen2 deleted the fix-cta-layout branch January 29, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcolloran bcolloran bcolloran approved these changes

Assignees

@ericpgreen2 ericpgreen2

Labels
blocker A release blocker issue that should be resolved before a new release Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpgreen2 @bcolloran