Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix spinner gradient #3933

Merged
merged 5 commits into from
Jan 30, 2024
Merged

fix spinner gradient #3933

merged 5 commits into from
Jan 30, 2024

Conversation

bcolloran
Copy link
Contributor

fixes #3913

default brand theme:
firefox_OCp4dYBc7c

custom user theme from orange to green
firefox_N3ldMBhFsY

@bcolloran bcolloran self-assigned this Jan 29, 2024
@bcolloran
Copy link
Contributor Author

fixes #3905 and #3913

@ericpgreen2 ericpgreen2 mentioned this pull request Jan 29, 2024
Closed
jkhwu
jkhwu requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@jkhwu jkhwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time of my review, it seems the spinner color is darker than intended in the design, which was secondary 500 - primary 500. I think they're both set to 700 in this branch. Here's a gif of what I'm seeing.
Jan-29-2024 23-13-04

@bcolloran
Copy link
Contributor Author

@jkhwu updated to 500/500. Sorry about that, when I was doing the fix I was looking at the theme regression bug #3913 and trying to match that previous state, and I didn't spot the callout for the new gradients in #3905

@ericpgreen2 ericpgreen2 merged commit cce1b20 into main Jan 30, 2024
4 checks passed
@ericpgreen2 ericpgreen2 deleted the fix-3913-spinner-gradient branch January 30, 2024 19:13
ericpgreen2 pushed a commit that referenced this pull request Jan 31, 2024
@bcolloran @ericpgreen2
Fix spinner gradient (#3933)
a104308 
* fix spinner gradient

* lint fixes

* more fixes

* another try at lint fix

* update spinner gradient endpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkhwu jkhwu jkhwu approved these changes

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

Assignees

@bcolloran bcolloran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible regression to custom themes
3 participants
@bcolloran @ericpgreen2 @jkhwu